SITL: support up to 32 rotors in a frame #29015
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tpwrules
reviewed
Jan 6, 2025
libraries/SITL/SIM_Frame.h
Outdated
| @@ -133,9 +137,9 @@ class Frame { | |||
| Vector3f moment_of_inertia; | |||
|
|
|||
| // if zero will no be used | |||
There was a problem hiding this comment.
Suggested change
| // if zero will no be used | |
| // if the motor position is zero, it will not be used |
Presumably?
There was a problem hiding this comment.
I have no idea. Pre-existing, and I wonder if it made sense to the original author or whether the relevant code has gone away!
... also, I'm not sure your new suggestion is accurate, given https://github.com/ardupilot/ardupilot/blob/master/libraries/SITL/SIM_Motor.cpp#L188
There was a problem hiding this comment.
Just remove it then? How do we note frames with less than 32 motors?
There was a problem hiding this comment.
Just remove it then? How do we note frames with less than 32 motors?
Removed it.
My guess is that we got num_motors as a thing and started to magically generate some of the motor layouts.
peterbarker
force-pushed
the
pr/sim-frame-max-actuators
branch
from
98fb310 to
c5efa05
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extracted from #27598